Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Template Access grid being initially empty when creating a new TV #16678

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Jan 14, 2025

What does it do?

Adds base grid method to differentiate the intent of the category URL param, between being the value of a grid filter and that of the target category for a new Element (when choosing Create a [Element] Here via the contextual menu), and applies the appropriate value for each context.

Why is it needed?

The Template Access grid initially is empty when a new Element is created in the root (i.e., it has no category), because the value of the category param is 'undefined'.

How to test

  1. Create new Elements of each type to verify normal operation.
  2. Pay specific attention to the Template and TV Elements, where each has an assignment grid (Template Variables and Template Access tabs respectively). Verify these grids show as expected and are unfiltered when creating a new Element and when editing an existing one.
  3. On an existing Template and TV, go to the respective assignment grid tab and use its category filter. Copy and paste the resulting URL (in the browser URL bar) and copy that into a new browser tab. Verify that the view in this new tab is the same as the previous tab where you applied the filter. (This is to ensure the somewhat new feature of grid filtering persistence via the URL still operates correctly.)

Related issue(s)/PR(s)

Resolves #16677

Formatting, code style and optimizations changes only
Adds logic to prevent the category request param from interfering with the display of certain grids and their category filtering combo; clarifies what that param signifies in the URL and how it's used
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.0 Issue with New TV Template Assignment
1 participant